RFR: 8272746: ZipFile can't open big file (NegativeArraySizeException) [v3]

Masanori Yano myano at openjdk.java.net
Mon Jan 17 09:56:16 UTC 2022


On Fri, 14 Jan 2022 23:55:58 GMT, Lance Andersen <lancea at openjdk.org> wrote:

>> Masanori Yano has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   8272746: ZipFile can't open big file (NegativeArraySizeException)
>
> Thank you for making the changes.  Overall it looks much better
> 
> Please add comments describing your constants as well as a comment describing  the intent of your setup and test methods

@LanceAndersen As you pointed out, I described the explanation of the test in the comment. Is there anything else I should fix?

-------------

PR: https://git.openjdk.java.net/jdk/pull/6927


More information about the core-libs-dev mailing list