RFR: 8272746: ZipFile can't open big file (NegativeArraySizeException) [v4]

[Lance Andersen]

On Mon, 17 Jan 2022 09:56:13 GMT, Masanori Yano <myano at openjdk.org> wrote:

>> Could you please review the JDK-8272746 bug fixes?
>> Since the array index is of type int, the overflow occurs when the value of end.cenlen is too large because of too many entries.
>> It is necessary to read a part of the CEN from the file to fix the problem fundamentally, but the way will require an extensive fix and degrade performance.
>> In practical terms, the size of the central directory rarely grows that large. So, I fixed it to check the size of the central directory and throw an exception if it is too large.
>
> Masanori Yano has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8272746: ZipFile can't open big file (NegativeArraySizeException)

Looks fine.  One minor comment update but you can integrate after making the change

test/jdk/java/util/zip/ZipFile/TestTooManyEntries.java line 82:

> 80: 
> 81:     /**
> 82:      * Validates that an appropriate exception is thrown when the ZipFile class

Please change "appropriate" to "ZipException"

-------------

Marked as reviewed by lancea (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/6927