RFR: JDK-8277795: ldap connection timeout not honoured under contention [v3]

[Rob McKenna]

On Thu, 13 Jan 2022 01:02:38 GMT, Mark Sheppard <msheppar at openjdk.org> wrote:

>> Rob McKenna has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Allow the test to pass on MacOSX
>
> src/java.naming/share/classes/com/sun/jndi/ldap/pool/PooledConnectionFactory.java line 54:
> 
>> 52:      * @param timeout the connection timeout
>> 53:      */
>> 54:     public abstract PooledConnection createPooledConnection(PoolCallback pcb, long timeout)
> 
> why not use int timeout to be consistent with existing code ?
> You've been required to "squash" it into an int in the factory ?

IIRC this was a request from an earlier review. (long being the standard throughout other new public apis) I'm happy with either, but int does avoid the trouble of casting.

-------------

PR: https://git.openjdk.java.net/jdk/pull/6568