RFR: 8279842: HTTPS Channel Binding support for Java GSS/Kerberos [v3]

[Michael Osipov]

On Fri, 21 Jan 2022 13:35:53 GMT, Michael McMahon <michaelm at openjdk.org> wrote:

>> src/java.naming/share/classes/com/sun/jndi/ldap/sasl/LdapSasl.java line 133:
>> 
>>> 131:                                 (String)env.get(TlsChannelBinding.CHANNEL_BINDING_TYPE));
>>> 132:                 } catch (ChannelBindingException e) {
>>> 133:                     throw new SaslException(e.getMessage(), e);
>> 
>> Why not ust pass the exception if the API allows? This looks like message duplication.
>
> Actually, it turns out I should be throwing `NamingException` here. That is what was being thrown by `TlsChannelBinding.parseType` before and an existing test was expecting that. NamingException only takes a String message. So, there won't be a root cause exception.

`NamingException` has `setRootCause()`. Why not use that? I use that one too and full stack is retained.

-------------

PR: https://git.openjdk.java.net/jdk/pull/7065