RFR: 8279842: HTTPS Channel Binding support for Java GSS/Kerberos [v3]

[Michael McMahon]

On Fri, 21 Jan 2022 13:38:08 GMT, Michael McMahon <michaelm at openjdk.org> wrote:

>> src/java.base/share/classes/sun/net/www/http/HttpClient.java line 189:
>> 
>>> 187:         } else {
>>> 188:             logError("Unexpected value for \"jdk.https.negotiate.cbt\" system property");
>>> 189:             return s;
>> 
>> Should this return either "always" or "never" instead? It seems that junk values will be treated as "always". It would be better to make it clear here.
>
> It was being handled elsewhere as "never". But, I agree it would be clearer to normalise it to "never" here.

Sorry, I should have checked back to the source rather than the snippet quoted. The problem is that the logError call is in the wrong place. It should be before line 186.

-------------

PR: https://git.openjdk.java.net/jdk/pull/7065