RFR: 8280459: Suspicious integer division in Hashtable.readHashtable

Roger Riggs rriggs at openjdk.java.net
Fri Jan 21 16:27:41 UTC 2022


On Fri, 21 Jan 2022 15:19:38 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

> Found by Sonar. See details in the bug.
> 
> Additional testing:
>  - [x] Linux x86_64 fastdebug `tier1`
>  - [x] Linux x86_64 fastdebug `java/util/Hashtable`

LGTM.  Seems reasonable though it might increase heap allocation of the array slightly.
In the example, the 28 would be reduced to 27 to make it odd.
With the new computation, its 29 or 2 additional refs.

-------------

Marked as reviewed by rriggs (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/7178


More information about the core-libs-dev mailing list