RFR: JDK-8277795: ldap connection timeout not honoured under contention [v3]
Mark Sheppard
msheppar at openjdk.java.net
Fri Jan 21 17:10:42 UTC 2022
On Fri, 21 Jan 2022 13:02:36 GMT, Rob McKenna <robm at openjdk.org> wrote:
>> Well I guess the request was "why not use long everywhere to avoid casting to int" ;-)
>> But I'm happy with either too - as long as the place where you have a long (e.g obtained by substracting two nano times) and call a method that takes an int has the proper guards in place, and either assert/throws/floor or ceil if the assumptions are not met - provided that a comment explains why that particular alternative is selected.
>
> Good point. I think its better to deal with the casts at the edges since the timeout handling will use long by default.
yes a redeclaration of timeout with a type long across the component would be a consistent approach, also
-------------
PR: https://git.openjdk.java.net/jdk/pull/6568
More information about the core-libs-dev
mailing list