RFR: 8279842: HTTPS Channel Binding support for Java GSS/Kerberos [v10]

[Weijun Wang]

On Wed, 26 Jan 2022 16:25:24 GMT, Daniel Fuchs <dfuchs at openjdk.org> wrote:

>> Michael McMahon has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   removed ^M from test
>
> test/jdk/sun/security/krb5/auto/HttpsCB.java line 120:
> 
>> 118: 
>> 119:         boolean expected1 = Boolean.parseBoolean(args[0]);
>> 120:         boolean expected2 = Boolean.parseBoolean(args[1]);
> 
> It might be better for future maintainers and readability if these two variables could have better names, and possibly a comment to explain their purpose. AFAIU it's the expected result of running with/without CBT - where `true` means that the operation should succeed and `false` that it's expected to fail with some exception...

Maybe `expectedCbtUrlResult` and `expectedNormalUrlResult`.

-------------

PR: https://git.openjdk.java.net/jdk/pull/7065