RFR: JDK-8280744: Allow SuppressWarnings to be used in package declarations [v4]

Iris Clark iris at openjdk.java.net
Fri Jan 28 00:03:12 UTC 2022


On Thu, 27 Jan 2022 23:27:54 GMT, Joe Darcy <darcy at openjdk.org> wrote:

>> The SuppressWarnings annotation type is declared have multiple targets, including modules; however, "package" is left off of its target list. As package-info file are another kind of declaration where a compiler could give warnings, allowing SuppressWarnings in that case is reasonable. Wanting SuppressWarnings in package-info file came up while working on doclint warnings (JDK-8280534). 
>> 
>> Please also review the companion CSR:
>> https://bugs.openjdk.java.net/browse/JDK-8280745
>> 
>> While the SuppressWarnings annotation does have a JLS section (9.6.4.5. @SuppressWarnings), the section doesn't mention the target list therefore doesn't appear to need to be updated.
>
> Joe Darcy has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision:
> 
>  - Respond to review feedback.
>  - Merge branch 'master' into JDK-8280744
>  - Respond to CSR feedback.
>  - Respond to review feedback.
>  - JDK-8280745: Allow SuppressWarnings to be used in package declarations

The current spec changes correspond to the approved CSR.

-------------

Marked as reviewed by iris (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/7239


More information about the core-libs-dev mailing list