[jdk19] RFR: 8289030: [macos] app image signature invalid when creating DMG or PKG [v2]

Alexander Matveev almatvee at openjdk.org
Thu Jul 7 07:27:56 UTC 2022


> Fixed 3 issues which made signature invalid:
> - We should not remove .jpackage.xml from signed app image when creating DMG or PKG otherwise it invalidates signature.
> - .package should be created when app image is generated, so this file can be signed.
> - Copying predefine app image for DMG and PKG should not follow symbolic links, otherwise several files from runtime (COPYRIGHT and LICENSE) will be copied instead of symbolic links being created, since it invalidates signature as well.
> 
> Added additional test to validate signature when DMG or PKG is generated from predefined app image.

Alexander Matveev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:

 - Merge remote-tracking branch 'upstream/master' into JDK-8289030
 - 8289030: [macos] app image signature invalid when creating DMG or PKG [v2]
 - 8289030: [macos] app image signature invalid when creating DMG or PKG

-------------

Changes:
  - all: https://git.openjdk.org/jdk19/pull/89/files
  - new: https://git.openjdk.org/jdk19/pull/89/files/5e47a1e3..4d5d4bce

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk19&pr=89&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk19&pr=89&range=00-01

  Stats: 1986 lines in 64 files changed: 1671 ins; 95 del; 220 mod
  Patch: https://git.openjdk.org/jdk19/pull/89.diff
  Fetch: git fetch https://git.openjdk.org/jdk19 pull/89/head:pull/89

PR: https://git.openjdk.org/jdk19/pull/89


More information about the core-libs-dev mailing list