[jdk19] RFR: 8289030: [macos] app image signature invalid when creating DMG or PKG [v3]

[Alexander Matveev]

On Thu, 7 Jul 2022 19:52:57 GMT, Alexey Semenyuk <asemenyuk at openjdk.org> wrote:

>> We need to add `.package` file during app image creation, since we need to sign it. With your proposed change we will add `.package` file to already signed app image.
>
> Oh, right.
> Anyways let's keep `.package`-related stuff away from AbstractAppImageBuilder.java, and AppImageBundler.java.
> 
> I'd move `.package`-related logic from AbstractAppImageBuilder to MacAppImageBuilder and change
> 
> public MacAppBundler() {
>         setAppImageSupplier(MacAppImageBuilder::new);
>         setParamsValidator(MacAppBundler::doValidate);
>     }
> 
> to something like this
> 
> public MacAppBundler() {
>        public MacAppBundler() {
>         setAppImageSupplier(imageOutDir -> {
>             return new MacAppImageBuilder(imageOutDir, isDependentTask());
>         });
>         setParamsValidator(MacAppBundler::doValidate);
>     }
> 
> 
> Need to add `AppImageBundler.sDependentTask()` method and change signature if MacAppImageBuilder ctor from `MacAppImageBuilder(Path imageOutDir)` to `MacAppImageBuilder(Path imageOutDir, boolean withPackageFile)`

Fixed.

-------------

PR: https://git.openjdk.org/jdk19/pull/89