RFR: 8290264 : java/util/concurrent/locks/Lock/OOMEInAQS.java fails with "exit code: 0"
David Holmes
dholmes at openjdk.org
Thu Jul 14 13:37:09 UTC 2022
On Thu, 14 Jul 2022 11:57:37 GMT, Doug Lea <dl at openjdk.org> wrote:
> This test now conforms to jtreg rules about not using System.exit to cover untested OutOfMemoryErrors
Hi Doug,
One pre-existing style nit but otherwise the termination logic seems okay.
Thanks.
test/jdk/java/util/concurrent/locks/Lock/OOMEInAQS.java line 108:
> 106: cond.signalAll();
> 107: } finally {
> 108: lock.unlock();
Pre-existing but the lock() should be before the try block (even if now it can't throw exceptions).
-------------
Marked as reviewed by dholmes (Reviewer).
PR: https://git.openjdk.org/jdk/pull/9491
More information about the core-libs-dev
mailing list