RFR: 8289511: Axes: child [v3]

Bill Huang duke at openjdk.org
Thu Jul 14 21:23:13 UTC 2022


On Thu, 14 Jul 2022 20:59:33 GMT, Joe Wang <joehw at openjdk.org> wrote:

>> Bill Huang has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Renamed XPahtExpChildTest.java and moved NPE test cases from invalid test case to zero children test case.
>
> test/jaxp/javax/xml/jaxp/unittest/xpath/XPathExpChildTest.java line 99:
> 
>> 97:                 // position
>> 98:                 {"/store/child::book[position()=1]/author", AUTHOR_1},
>> 99:                 {"/store/child::book[last()]/author", AUTHOR_2},
> 
> If the intention is to test the last() function, it would be good to have more books than 2 (e.g. at least 3). But if the focus is on Axes: child, plus functions will be tested in the other subtask, I'm ok if you don't want to make further changes.

Noted. We will cover that in the XPath function() test.

-------------

PR: https://git.openjdk.org/jdk/pull/9484


More information about the core-libs-dev mailing list