RFR: 8289643: File descriptor leak with ProcessBuilder.startPipeline [v7]

[Roger Riggs]

On Fri, 8 Jul 2022 13:29:12 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:

>> Roger Riggs has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 10 additional commits since the last revision:
>> 
>>  - Remove diagnostics output from ProcessBuilder
>>  - Merge branch '8289643-pipeline-start-leak' of https://github.com/RogerRiggs/jdk into 8289643-pipeline-start-leak
>>  - Add DEBUG diagnostics to determine cause of GitHub Action test failures due to unexpected pipes
>>  - Merge branch 'master' into 8289643-pipeline-start-leak
>>  - Add DEBUG diagnostics to determine cause of GitHub Action test failures due to unexpected pipes
>>  - Use DirectoryStream and handle IOExceptions
>>  - remove debug output
>>  - Add TWR for Files.walk of /proc
>>  - Cleanup of PipelineLeaksFD test improving error messages and source cleanup.
>>  - 8289643: File descriptor leak with ProcessBuilder.startPipeline
>
> test/jdk/java/lang/ProcessBuilder/PipelineLeaksFD.java line 101:
> 
>> 99: 
>> 100:         Set<PipeRecord> pipesAfter = myPipes();
>> 101:         if (!pipesBefore.equals(pipesAfter)) {
> 
> Since `myPipes()` can return null, should there be a null check here for `pipesBefore`?

No longer returns null.

-------------

PR: https://git.openjdk.org/jdk/pull/9414