RFR: 8290353: ModuleReader::list specification should suggest closing the returned stream [v3]

Ryan Ernst duke at openjdk.org
Tue Jul 19 14:06:52 UTC 2022


> This commit adds additional clarification to the javadocs of
> ModuleReader::list about needing to close the stream. The new wording is
> similar to that used in Files::find and other similar methods.

Ryan Ernst has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision:

 - Merge branch 'master' into try_files/module_reader
 - Revert "fix uses of list() in java.base"
   
   This reverts commit a72a5b9ec4e22ca4a414554b722042d4cbfaef58.
 - adjust wording
 - fix uses of list() in java.base
 - 8290353: Clarify the streams returned by ModuleReader::list
   
   This commit adds additional clarification to the javadocs of
   ModuleReader::list about needing to close the stream. The new wording is
   similar to that used in Files::find and other similar methods.

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/9538/files
  - new: https://git.openjdk.org/jdk/pull/9538/files/0b3ca182..181c47a1

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=9538&range=02
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=9538&range=01-02

  Stats: 1282 lines in 88 files changed: 948 ins; 133 del; 201 mod
  Patch: https://git.openjdk.org/jdk/pull/9538.diff
  Fetch: git fetch https://git.openjdk.org/jdk pull/9538/head:pull/9538

PR: https://git.openjdk.org/jdk/pull/9538


More information about the core-libs-dev mailing list