RFR: 8290353: ModuleReader::list specification should suggest closing the returned stream [v3]
Mandy Chung
mchung at openjdk.org
Tue Jul 19 16:17:06 UTC 2022
On Tue, 19 Jul 2022 14:06:52 GMT, Ryan Ernst <duke at openjdk.org> wrote:
>> This commit adds additional clarification to the javadocs of
>> ModuleReader::list about needing to close the stream. The new wording is
>> similar to that used in Files::find and other similar methods.
>
> Ryan Ernst has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision:
>
> - Merge branch 'master' into try_files/module_reader
> - Revert "fix uses of list() in java.base"
>
> This reverts commit a72a5b9ec4e22ca4a414554b722042d4cbfaef58.
> - adjust wording
> - fix uses of list() in java.base
> - 8290353: Clarify the streams returned by ModuleReader::list
>
> This commit adds additional clarification to the javadocs of
> ModuleReader::list about needing to close the stream. The new wording is
> similar to that used in Files::find and other similar methods.
Marked as reviewed by mchung (Reviewer).
Looks good to me. I reviewed the CSR.
-------------
PR: https://git.openjdk.org/jdk/pull/9538
More information about the core-libs-dev
mailing list