RFR: 8290471: jpackage: allow to specify codepage on Windows [v2]
Alex Kasko
akasko at openjdk.org
Wed Jul 20 16:52:04 UTC 2022
> It is proposed to introduce support for `--win-codepage` argument, and substitute the `Codepage` attribute with `--win-codepage` specified value in primary l10n file when it is being copied to the config dir.
>
> Instead of copying all internal l10n files, it is proposed to copy only the primary file. Plain copy is used if `--win-codepage` is not specified. Otherwise `--win-codepage` value is substituted in l10n file using DOM and XPath.
>
> See more details in issue description and in links added there.
>
> Testing:
>
> - [x] ran `jtreg:jdk/tools/jpackage`
> - [x] test for `--win-codepage` argument is included with the patch
Alex Kasko has updated the pull request incrementally with two additional commits since the last revision:
- extend the test to cover utf-8 codepage
- new argument description in --help output
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/9546/files
- new: https://git.openjdk.org/jdk/pull/9546/files/aefec1ce..0e4241ce
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=9546&range=01
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=9546&range=00-01
Stats: 58 lines in 5 files changed: 44 ins; 0 del; 14 mod
Patch: https://git.openjdk.org/jdk/pull/9546.diff
Fetch: git fetch https://git.openjdk.org/jdk pull/9546/head:pull/9546
PR: https://git.openjdk.org/jdk/pull/9546
More information about the core-libs-dev
mailing list