RFR: 8290504: Close streams returned by ModuleReader::list [v2]

Petr Portnov | PROgrm_JARvis duke at openjdk.org
Wed Jul 20 21:16:05 UTC 2022


On Wed, 20 Jul 2022 20:58:55 GMT, Ryan Ernst <duke at openjdk.org> wrote:

>> This commit ensures streams returned by ModuleReader::list are closed.
>
> Ryan Ernst has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
> 
>  - Merge branch 'master' into try_files/module_reader_uses
>  - revert CallerSensitiveAccess change
>  - 8290504: Close streams returned by ModuleReader::list
>    
>    This commit ensures streams returned by ModuleReader::list are closed.

Changes requested by JarvisCraft at github.com (no known OpenJDK username).

src/java.base/share/classes/jdk/internal/module/ModuleHashes.java line 118:

> 116:             throw new IllegalArgumentException(e);
> 117:         }
> 118:         try (Stream<String> stream = reader.list()){

Suggestion:

        try (Stream<String> stream = reader.list()) {

-------------

PR: https://git.openjdk.org/jdk/pull/9557


More information about the core-libs-dev mailing list