RFR: JDK-8289948: Improve test coverage for XPath functions: Node Set Functions [v4]

Bill Huang duke at openjdk.org
Thu Jul 28 01:42:16 UTC 2022


On Thu, 28 Jul 2022 00:14:52 GMT, Joe Wang <joehw at openjdk.org> wrote:

>> Bill Huang has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Added documentation/comments and test cases using namespace.
>
> test/jaxp/javax/xml/jaxp/unittest/xpath/XPathExpFnTest.java line 38:
> 
>> 36:  * @library /javax/xml/jaxp/unittest
>> 37:  * @run testng xpath.XPathExpFnTest
>> 38:  * @summary Test for XPath functions
> 
> Since this test focuses on Node Set Functions, it would be good to say so, e.g. "Tests the XPath Node Set Functions".

Agreed. I think it would be good to rename this file to XPathNodeSetFnTest.java.

-------------

PR: https://git.openjdk.org/jdk/pull/9633


More information about the core-libs-dev mailing list