RFR: 8273346: Expand library mappings to IEEE 754 operations [v2]
Raffaello Giulietti
duke at openjdk.java.net
Wed Jun 1 08:45:35 UTC 2022
On Wed, 1 Jun 2022 02:05:40 GMT, Joe Darcy <darcy at openjdk.org> wrote:
>> Generally add apiNote's to map from Java library methods to particular IEEE 754 operations. For now, I only added such notes to java.lang.Math and not java.lang.StrictMath.
>
> Joe Darcy has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision:
>
> - Respond to review feedback; make another pass to link methods to IEEE 754 operations.
> - Merge branch 'master' into JDK-8273346
> - Add floor and ceil.
> - JDK-8273346: Examine use of "rounding mode" and "rounding policy" in Math and StrictMath
src/java.base/share/classes/java/lang/Math.java line 823:
> 821: * @apiNote
> 822: * This method corresponds to the convertTowardPositive operation
> 823: * defined in IEEE 754.
Probably what is meant is IEEE `convertToIntegerTowardPositive` (not `convertTowardPositive`).
However, that's another kind of rounding, which always rounds any non-integral value toward positive infinity, not just ties. This is not what happens with this method.
-------------
PR: https://git.openjdk.java.net/jdk/pull/8876
More information about the core-libs-dev
mailing list