RFR: 8283660: Convert com/sun/jndi/ldap/AbstractLdapNamingEnumeration.java finalizer to Cleaner [v9]
Brent Christian
bchristi at openjdk.java.net
Fri Jun 3 17:56:44 UTC 2022
> Please review this change to replace the finalizer in `AbstractLdapNamingEnumeration` with a Cleaner.
>
> The pieces of state required for cleanup (`LdapCtx homeCtx`, `LdapResult res`, and `LdapClient enumClnt`) are moved to a static inner class . From there, the change is fairly mechanical.
>
> Details of note:
> 1. Some operations need to change the state values (the update() method is probably the most interesting).
> 2. Subclasses need to access `homeCtx`; I added a `homeCtx()` method to read `homeCtx` from the superclass's `state`.
>
> The test case is based on a copy of `com/sun/jndi/ldap/blits/AddTests/AddNewEntry.java`. A more minimal test case might be possible, but this was done for expediency.
>
> The test only confirms that the new Cleaner use does not keep the object reachable. It only tests `LdapSearchEnumeration` (not `LdapNamingEnumeration` or `LdapBindingEnumeration`, though all are subclasses of `AbstractLdapNamingEnumeration`).
>
> Thanks.
Brent Christian has updated the pull request incrementally with two additional commits since the last revision:
- Update .ldap capture file
- Check that cleanup was performed correctly
-------------
Changes:
- all: https://git.openjdk.java.net/jdk/pull/8311/files
- new: https://git.openjdk.java.net/jdk/pull/8311/files/4af66bff..3941e6f1
Webrevs:
- full: https://webrevs.openjdk.java.net/?repo=jdk&pr=8311&range=08
- incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=8311&range=07-08
Stats: 86 lines in 2 files changed: 34 ins; 38 del; 14 mod
Patch: https://git.openjdk.java.net/jdk/pull/8311.diff
Fetch: git fetch https://git.openjdk.java.net/jdk pull/8311/head:pull/8311
PR: https://git.openjdk.java.net/jdk/pull/8311
More information about the core-libs-dev
mailing list