RFR: 8283660: Convert com/sun/jndi/ldap/AbstractLdapNamingEnumeration.java finalizer to Cleaner [v13]
Brent Christian
bchristi at openjdk.java.net
Tue Jun 7 21:31:38 UTC 2022
> Please review this change to replace the finalizer in `AbstractLdapNamingEnumeration` with a Cleaner.
>
> The pieces of state required for cleanup (`LdapCtx homeCtx`, `LdapResult res`, and `LdapClient enumClnt`) are moved to a static inner class . From there, the change is fairly mechanical.
>
> Details of note:
> 1. Some operations need to change the state values (the update() method is probably the most interesting).
> 2. Subclasses need to access `homeCtx`; I added a `homeCtx()` method to read `homeCtx` from the superclass's `state`.
>
> The test case is based on a copy of `com/sun/jndi/ldap/blits/AddTests/AddNewEntry.java`. A more minimal test case might be possible, but this was done for expediency.
>
> The test only confirms that the new Cleaner use does not keep the object reachable. It only tests `LdapSearchEnumeration` (not `LdapNamingEnumeration` or `LdapBindingEnumeration`, though all are subclasses of `AbstractLdapNamingEnumeration`).
>
> Thanks.
Brent Christian has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 23 commits:
- Merge branch 'master' into remove-finalizers
- reference emunCtx and homeCtx consistently in constructor
- Restore EnumCtx to being an inner class, to keep all the state together in the code
- Restore comments in ldap capture file
- Update test files - add copyright, etc
- added getters to EnumCtx, and moved it to top level ; use getters + local variables to reduce code changes
- test comment udpate
- Update .ldap capture file
- Check that cleanup was performed correctly
- Merge branch 'master' into remove-finalizers
- ... and 13 more: https://git.openjdk.java.net/jdk/compare/b7a34f72...afd1c9b5
-------------
Changes: https://git.openjdk.java.net/jdk/pull/8311/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=8311&range=12
Stats: 623 lines in 6 files changed: 352 ins; 103 del; 168 mod
Patch: https://git.openjdk.java.net/jdk/pull/8311.diff
Fetch: git fetch https://git.openjdk.java.net/jdk pull/8311/head:pull/8311
PR: https://git.openjdk.java.net/jdk/pull/8311
More information about the core-libs-dev
mailing list