RFR: 8287007: [cgroups] Consistently use stringStream throughout parsing code [v2]

Severin Gehwolf sgehwolf at openjdk.java.net
Wed Jun 8 12:12:36 UTC 2022


On Wed, 8 Jun 2022 08:25:21 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

>> src/hotspot/os/linux/cgroupV1Subsystem_linux.cpp line 54:
>> 
>>> 52:       } else {
>>> 53:         char *p = strstr(cgroup_path, _root);
>>> 54:         if (p != NULL && p == cgroup_path) {
>> 
>> I think this change should be done in a separate bug, because it will cause the `if` block to be executed. Previously the `if` block is never executed (unless `cgroup_path == _root` ??, but then it will just set `_path` to the same string as `_mount_point`) -- so we don't even know if this change of behavior might do something harmful.
>
> OK. Then this will remain to be dead code and I'll remove the corresponding test case in the new `gtests` too (as they'd otherwise fail in contrast to the Java code).

Done.

-------------

PR: https://git.openjdk.java.net/jdk/pull/8969


More information about the core-libs-dev mailing list