RFR: 8288011: StringConcatFactory: Split application of stringifiers [v2]

Claes Redestad redestad at openjdk.java.net
Thu Jun 9 16:04:43 UTC 2022


> To take optimal advantage of the pre-existing optimization for repeated filters we could split the application of different types of stringifiers.
> 
> The resulting difference in order of evaluation is not observable by conventional means since all reference type share the same object stringifier, and the others are filtering primitives (floats and doubles) which have been passed by value already. 
> 
> This change neutral on many concatenation expression shapes, but for any complex expressions with interleaving float/double and reference parameters it brings a straightforward reduction in rebinds and underlying LFs generated. For example on the [MixedStringCombinations.java](https://gist.github.com/cl4es/08fb581dece3a73e89bfa52337bc4248) test there's a modest 2% reduction in total classes loaded with this change (from 16209 to 15872)

Claes Redestad has updated the pull request incrementally with one additional commit since the last revision:

  Improve comments based on review feedback

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/9082/files
  - new: https://git.openjdk.org/jdk/pull/9082/files/51c841e8..4b7c696e

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=9082&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=9082&range=00-01

  Stats: 11 lines in 1 file changed: 7 ins; 2 del; 2 mod
  Patch: https://git.openjdk.org/jdk/pull/9082.diff
  Fetch: git fetch https://git.openjdk.org/jdk pull/9082/head:pull/9082

PR: https://git.openjdk.org/jdk/pull/9082


More information about the core-libs-dev mailing list