RFR: 8285405: add test and check for negative argument to HashMap::newHashMap et al

Stuart Marks smarks at openjdk.java.net
Thu Jun 9 23:16:08 UTC 2022


On Mon, 6 Jun 2022 06:57:23 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:

> Can I please get a review of this change which addresses https://bugs.openjdk.java.net/browse/JDK-8285405?
> 
> I've added the test for `LinkedHashMap.newLinkedHashMap(int)` in the existing `test/jdk/java/util/LinkedHashMap/Basic.java` since that test has tests for various APIs of this class.
> 
> For `WeakHashMap.newWeakHashMap` and `HashMap.newHashMap`, I have created new test classes under relevant locations, since these classes already have test classes (almost) per API/feature in those locations.

Note that I've integrated [JDK-8284780](https://bugs.openjdk.org/browse/JDK-8284780) (HashSet static factories) so maybe this PR could be updated with tests for those as well.

-------------

PR: https://git.openjdk.org/jdk/pull/9036


More information about the core-libs-dev mailing list