RFR: 8285405: add test and check for negative argument to HashMap::newHashMap et al [v3]
Jaikiran Pai
jpai at openjdk.java.net
Fri Jun 10 08:26:02 UTC 2022
> Can I please get a review of this change which addresses https://bugs.openjdk.java.net/browse/JDK-8285405?
>
> I've added the test for `LinkedHashMap.newLinkedHashMap(int)` in the existing `test/jdk/java/util/LinkedHashMap/Basic.java` since that test has tests for various APIs of this class.
>
> For `WeakHashMap.newWeakHashMap` and `HashMap.newHashMap`, I have created new test classes under relevant locations, since these classes already have test classes (almost) per API/feature in those locations.
Jaikiran Pai has updated the pull request incrementally with one additional commit since the last revision:
add newline at the end of the new file
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/9036/files
- new: https://git.openjdk.org/jdk/pull/9036/files/07bbaa91..ba159d14
Webrevs:
- full: https://webrevs.openjdk.java.net/?repo=jdk&pr=9036&range=02
- incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=9036&range=01-02
Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
Patch: https://git.openjdk.org/jdk/pull/9036.diff
Fetch: git fetch https://git.openjdk.org/jdk pull/9036/head:pull/9036
PR: https://git.openjdk.org/jdk/pull/9036
More information about the core-libs-dev
mailing list