RFR: 8287971: Throw exception for missing values in .jpackage.xml

Alexey Semenyuk asemenyuk at openjdk.java.net
Tue Jun 14 18:36:43 UTC 2022


On Mon, 13 Jun 2022 17:01:48 GMT, Alexander Matveev <almatvee at openjdk.org> wrote:

> - Error will be thrown if app image is generated with another JDK version or has malformed .jpackage.xml.
>  - Re-fixed as Alexey suggested in https://github.com/openjdk/jdk/pull/9098.

-

src/jdk.jpackage/share/classes/jdk/jpackage/internal/AppImageFile.java line 339:

> 337:                 !("true".equals(appStoreStr) || "false".equals(appStoreStr))) {
> 338:             return false;
> 339:         }

It makes sense to unfold this function in the ctor as we don't allow empty AppImageFile instances.

-------------

Changes requested by asemenyuk (Reviewer).

PR: https://git.openjdk.org/jdk19/pull/9


More information about the core-libs-dev mailing list