RFR: 8278863: Add method ClassDesc::ofInternalName [v2]

Jorn Vernee jvernee at openjdk.org
Fri Jun 17 17:27:57 UTC 2022


On Fri, 17 Jun 2022 17:03:52 GMT, Adam Sotona <asotona at openjdk.org> wrote:

>> The symbolic constants API (`java.lang.constant`) was designed, in part, to provide bytecode parsing and generation APIs with a validated, common, symbolic form for constants in Java class files. 
>> 
>> There is an easy way to create a `ClassDesc` from a binary name (`ClassDesc::of`) or a field descriptor (`ClassDesc::ofDescriptor`) but not from an internal name. But, the internal name is common in low-level bytecode-manipulation code. 
>> 
>> This patch adds `ClassDesc::ofInternalName` static factory method that creates a `ClassDesc` from class internal name.
>> Class internal name validation and extended ClassDescTest are also parts of this patch.
>> 
>> CSR is linked with the issue.
>> 
>> Please review.
>> 
>> Thank you,
>> Adam
>
> Adam Sotona has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Update test/jdk/java/lang/constant/ClassDescTest.java
>   
>   Co-authored-by: Jorn Vernee <JornVernee at users.noreply.github.com>

Thanks for explaining.

-------------

Marked as reviewed by jvernee (Reviewer).

PR: https://git.openjdk.org/jdk/pull/9201


More information about the core-libs-dev mailing list