RFR: 8288589: Files.readString ignores encoding errors for UTF-16 [v5]

Naoto Sato naoto at openjdk.org
Wed Jun 22 17:47:03 UTC 2022


On Wed, 22 Jun 2022 10:48:47 GMT, Alan Bateman <alanb at openjdk.org> wrote:

>> Naoto Sato has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Moved `@Test` annotations
>
> test/jdk/java/nio/file/Files/ReadWriteString.java line 304:
> 
>> 302:             throws IOException {
>> 303:         Path path = Files.createTempFile("illegalInputBytes", null);
>> 304:         path.toFile().deleteOnExit();
> 
> Although this is consistent with the existing tests in this source file, I think it would be better if we change it to create the temporary files in the current directory and not delete it. Leaving the file behind is useful for diagnosing issues where there re test failures. We can do that in a separate issue if you'd like.

Done.

-------------

PR: https://git.openjdk.org/jdk/pull/9193


More information about the core-libs-dev mailing list