RFR: 8288979: Improve CLDRConverter run time [v2]
Naoto Sato
naoto at openjdk.org
Wed Jun 22 18:02:07 UTC 2022
On Wed, 22 Jun 2022 17:27:11 GMT, Roger Riggs <rriggs at openjdk.org> wrote:
>> True. Which raises the question: do we need any arbitrary order? The original code used a hashmap too. It preserved the original order only when no duplicates were detected.
>
> A stable order is useful when comparing between builds (by a human).
> It also supports the goal of reproducible builds.
> @naotoj What do you think?
IIUC, once this fix makes it to the repository, the build will be reproducible. Making it to be sorted is a welcome enhancement (I compare the generated bundles manually from time to time), but it may be costly so it could defy the performance improvement?
-------------
PR: https://git.openjdk.org/jdk/pull/9243
More information about the core-libs-dev
mailing list