RFR: 8288495: [test] Make OutputAnalyzer exception more informative
Roger Riggs
rriggs at openjdk.org
Wed Jun 22 18:31:40 UTC 2022
The RuntimeException from OutputAnalyzer for expected and unexpected exit values should include both the actual and expected values.
The method `shouldHaveExitvalue` and `shouldNotHaveExitValue` include the value expected and the value not expected instead of the actual value returned. The values provided in the exception are already known quantities in the code, what is not known is the actual value.
The actual value is printed to stderr but not the expected value and in the logs, the exception report is frequently to stdout and therefor separated in the log from the output of stderr. Including both expected and actual values in the exception makes it easier to understand.
Exception messages should not include newlines.
-------------
Commit messages:
- 8288495: [test] Make OutputAnalyzer exception more informative
Changes: https://git.openjdk.org/jdk/pull/9247/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=9247&range=00
Issue: https://bugs.openjdk.org/browse/JDK-8288495
Stats: 46 lines in 2 files changed: 27 ins; 1 del; 18 mod
Patch: https://git.openjdk.org/jdk/pull/9247.diff
Fetch: git fetch https://git.openjdk.org/jdk pull/9247/head:pull/9247
PR: https://git.openjdk.org/jdk/pull/9247
More information about the core-libs-dev
mailing list