RFR: 8282036: [Test]: Update java/util/zip/ZipFile/DeleteTempJar.java to stop HttpServer cleanly in case of exceptions [v2]

Jaikiran Pai jpai at openjdk.org
Mon Jun 27 10:58:50 UTC 2022


On Mon, 27 Jun 2022 10:53:56 GMT, Thejasvi Voniadka <tvoniadka at openjdk.org> wrote:

>> This is a simple change to add some protective code to java/util/zip/ZipFile/DeleteTempJar.java so that the clean-up is more complete in the event of encountering an any exceptions while running. In the present state, the server.stop() does not get executed in case of encountering a failure. As a result, the test may get hung until a timeout. This fix should address the scenario.
>> 
>> The test passes on all supported platforms post fix.
>
> Thejasvi Voniadka has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8282036: [Test]: Update java/util/zip/ZipFile/DeleteTempJar.java to stop HttpServer cleanly in case of exceptions

test/jdk/java/util/zip/ZipFile/DeleteTempJar.java line 86:

> 84:             System.out.println(f.getName());
> 85:         } finally {
> 86:             if (server != null) {

The null check can be removed here as suggested by Alan.

-------------

PR: https://git.openjdk.org/jdk/pull/9293


More information about the core-libs-dev mailing list