RFR: 8284640: CollectorImpl class could be a record class

Roger Riggs rriggs at openjdk.org
Tue Jun 28 19:59:26 UTC 2022


On Mon, 11 Apr 2022 13:08:43 GMT, altrisi <duke at openjdk.org> wrote:

> Changes the definition of `CollectorImpl` to be a record.

For some new features, its an obvious yes, though personally, it should add some value to the code, not just churn the code base to be up-to-date.

Also, there is quite a bit of core code that is sensitive to bootstrap and startup performance regressions.
And occasionally it makes backports harder, though that's not a reason to be stuck with old APIs.

Using preview features can also be a mixed bag. The dependencies and warnings about using preview features can break the build and they are not always such an improvement to suppress the warnings and have to come back later to remove or redo the code.

Some parts of the system (like javac) have to be compiled with the previous JDK, so no new features.

Use new feature judiciously, meaning think broadly about the impact across the code base, not just a bit of code here and there.

-------------

PR: https://git.openjdk.org/jdk/pull/8179


More information about the core-libs-dev mailing list