RFR: 8289431: (zipfs) Avoid redundant HashMap.get in ZipFileSystemProvider.removeFileSystem [v2]

Lance Andersen lancea at openjdk.org
Wed Jun 29 09:59:40 UTC 2022


On Wed, 29 Jun 2022 08:20:31 GMT, Andrey Turbanov <aturbanov at openjdk.org> wrote:

>> There is overload method HashMap.remove(key,value) which also checks value equality.
>> It's shorter and faster than pair get+remove.
>
> Andrey Turbanov has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8289431: (zipfs) Avoid redundant HashMap.get in ZipFileSystemProvider.removeFileSystem
>   update copyright year

The change seems OK.  Note  that the `removeFileSystem` method is only called when zipfs is closed

-------------

Marked as reviewed by lancea (Reviewer).

PR: https://git.openjdk.org/jdk/pull/9314


More information about the core-libs-dev mailing list