RFR: 8282143: Objects.requireNonNull should be ForceInline [v2]
Quan Anh Mai
duke at openjdk.java.net
Tue Mar 1 02:22:49 UTC 2022
> Hi,
>
> `Objects.requireNonNull` may fail to be inlined. The call is expensive and may lead to objects escaping to the heap while the null check is cheap and is often elided. I have observed this when using the vector API when a call to `Objects.requireNonNull` leads to vectors being materialised in a hot loop.
>
> Should the other `requireNonNull` be `ForceInline` as well?
>
> Thank you very much.
Quan Anh Mai has updated the pull request incrementally with one additional commit since the last revision:
the other
-------------
Changes:
- all: https://git.openjdk.java.net/jdk/pull/7543/files
- new: https://git.openjdk.java.net/jdk/pull/7543/files/bcd22b9d..b362bdca
Webrevs:
- full: https://webrevs.openjdk.java.net/?repo=jdk&pr=7543&range=01
- incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=7543&range=00-01
Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod
Patch: https://git.openjdk.java.net/jdk/pull/7543.diff
Fetch: git fetch https://git.openjdk.java.net/jdk pull/7543/head:pull/7543
PR: https://git.openjdk.java.net/jdk/pull/7543
More information about the core-libs-dev
mailing list