RFR: 8281146: Replace StringCoding.hasNegatives with countPositives [v9]

Lutz Schmidt lucy at openjdk.java.net
Thu Mar 3 14:47:02 UTC 2022


On Thu, 3 Mar 2022 14:37:34 GMT, Andrew Haley <aph at openjdk.org> wrote:

> > > Well, it just didn't build. With the annotation being present, you also need an intrinsic implementation. That's what the error message is saying...
> > 
> > 
> > Doh, I had no idea the presence of `@IntrinsicCandidate` was mandating the VM has an intrinsic implementation these days (Why?! Not much of a _candidate_ if it's required..).
> 
> I don't think the intrinsic has to be implemented on every target, but AFAICR it does have to be declared as an intrinsic in HotSpot.

Yes, sorry for the imprecise wording: the declaration must be there. Use of the intrinsic is then controlled via has_match_rule(opcode) and match_rule_supported(opcode).

-------------

PR: https://git.openjdk.java.net/jdk/pull/7231


More information about the core-libs-dev mailing list