RFR: 8264160: Regex \b is not consistent with \w without UNICODE_CHARACTER_CLASS

Lance Andersen lancea at openjdk.java.net
Tue Mar 8 11:50:04 UTC 2022


On Fri, 18 Feb 2022 19:47:09 GMT, Ian Graves <igraves at openjdk.org> wrote:

> Proposed change in behavior to correct inconsistencies between `\w` and `\b` metacharacters

Have not gone through the javadoc changes in detail yet but plan to, only scanned it just now

On a quick skim of the test, it could use some TLC which you might consider doing now or later.  

It would be really good for future maintainers if there was a comment which introduced each test as to what it was trying to exercise (not just a bug number).  Same with some of the private helper methods.

You probably want to include your bug number in the @bug declaration which starts on line 27

test/jdk/java/util/regex/RegExTest.java line 4557:

> 4555: 
> 4556:     //This test is for 8264160
> 4557:     public static void wordBoundaryInconsistencies() {

There should be an `@Test` I believe as unless I missed it, this method is not called anywhere else

-------------

PR: https://git.openjdk.java.net/jdk/pull/7539


More information about the core-libs-dev mailing list