RFR: 8264160: Regex \b is not consistent with \w without UNICODE_CHARACTER_CLASS [v3]

Ian Graves igraves at openjdk.java.net
Wed Mar 9 01:33:48 UTC 2022


On Tue, 8 Mar 2022 18:54:13 GMT, Lance Andersen <lancea at openjdk.org> wrote:

>> Ian Graves has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains six commits:
>> 
>>  - Merge branch 'master' of https://github.com/openjdk/jdk into bug-8264160
>>  - Bug id's to header and some other cleanup
>>  - Fixing bad javadoc
>>  - Merge remote-tracking branch 'upstream/master' into bug-8264160
>>  - Updating spec
>>  - Proposed change for \b metacharacter
>
> test/jdk/java/util/regex/RegExTest.java line 65:
> 
>> 63: import java.util.stream.Stream;
>> 64: 
>> 65: import org.testng.annotations.DataProvider;
> 
> I don't see a DataProvider being used anywhere, perhaps you were and then decided against it?

Ah yes, thanks. I had originally written this test with a DataProvider, it proved to be a bit clunky and slower than it is now.

> test/jdk/java/util/regex/RegExTest.java line 4556:
> 
>> 4554:     }
>> 4555: 
>> 4556:     //This test is for 8264160
> 
> Even if you are not going to do a pass through existing tests to provide a comment of the tests intent as part of this PR, please do so for your additional tests.  Future maintainers will thank you :-)

Fixed as far back as I can remember for now!

-------------

PR: https://git.openjdk.java.net/jdk/pull/7539


More information about the core-libs-dev mailing list