RFR: 8282662: Use List/Set.of() factory methods to reduce memory consumption [v2]
liach
duke at openjdk.java.net
Wed Mar 9 16:12:13 UTC 2022
On Wed, 9 Mar 2022 08:35:45 GMT, Сергей Цыпанов <duke at openjdk.java.net> wrote:
>> `List.of()` along with `Set.of()` create unmodifiable `List/Set` but with smaller footprint comparing to `Arrays.asList()` / `new HashSet()` when called with vararg of size 0, 1, 2.
>>
>> In general replacement of `Arrays.asList()` with `List.of()` is dubious as the latter is null-hostile, however in some cases we are sure that arguments are non-null. Into this PR I've included the following cases (in addition to those where the argument is proved to be non-null at compile-time):
>> - `MethodHandles.longestParameterList()` never returns null
>> - parameter types are never null
>> - interfaces used for proxy construction and returned from `Class.getInterfaces()` are never null
>> - exceptions types of method signature are never null
>
> Сергей Цыпанов has updated the pull request incrementally with one additional commit since the last revision:
>
> 8282662: Revert dubious changes
src/java.base/share/classes/java/lang/invoke/MethodType.java line 910:
> 908: if (skipPos > myLen || myLen - skipPos > fullLen)
> 909: return false;
> 910: List<Class<?>> myList = List.of(ptypes);
imo should revert this one together with that proxy parameter one
-------------
PR: https://git.openjdk.java.net/jdk/pull/7729
More information about the core-libs-dev
mailing list