RFR: 8281146: Replace StringCoding.hasNegatives with countPositives [v13]
Claes Redestad
redestad at openjdk.java.net
Wed Mar 9 21:01:13 UTC 2022
> I'm requesting comments and, hopefully, some help with this patch to replace `StringCoding.hasNegatives` with `countPositives`. The new method does a very similar pass, but alters the intrinsic to return the number of leading bytes in the `byte[]` range which only has positive bytes. This allows for dealing much more efficiently with those `byte[]`s that has a ASCII prefix, with no measurable cost on ASCII-only or latin1/UTF16-mostly input.
>
> Microbenchmark results: https://jmh.morethan.io/?gists=428b487e92e3e47ccb7f169501600a88,3c585de7435506d3a3bdb32160fe8904
>
> - Only implemented on x86 for now, but I want to verify that implementations of `countPositives` can be implemented with similar efficiency on all platforms that today implement a `hasNegatives` intrinsic (aarch64, ppc etc) before moving ahead. This pretty much means holding up this until it's implemented on all platforms, which can either contributed to this PR or as dependent follow-ups.
>
> - An alternative to holding up until all platforms are on board is to allow the implementation of `StringCoding.hasNegatives` and `countPositives` to be implemented so that the non-intrinsified method calls into the intrinsified. This requires structuring the implementations differently based on which intrinsic - if any - is actually implemented. One way to do this could be to mimic how `java.nio` handles unaligned accesses and expose which intrinsic is available via `Unsafe` into a `static final` field.
>
> - There are a few minor regressions (~5%) in the x86 implementation on `encode-/decodeLatin1Short`. Those regressions disappear when mixing inputs, for example `encode-/decodeShortMixed` even see a minor improvement, which makes me consider those corner case regressions with little real world implications (if you have latin1 Strings, you're likely to also have ASCII-only strings in your mix).
Claes Redestad has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 40 commits:
- Merge branch 'master' into count_positives
- Restructure encodeUTF8 to reduce code gen issues
- use 32-bit mask to calculate correct remainder value
- ary1 not required to have USE_KILL effect
- Better implementation for aarch64 returning roughly the count of positive bytes
- Document that it's allowed for implementations to return values less than the exact count (iff there are negative bytes)
- Clean out and remove vmIntrinsics::_hasNegatives and all related code
- s390 impl provided by @RealLucy
- PPC impl provided by @TheRealMDoerr
- Narrow the bottom_type of CountPositivesNode (always results in a positive int value)
- ... and 30 more: https://git.openjdk.java.net/jdk/compare/ff766204...30739e15
-------------
Changes: https://git.openjdk.java.net/jdk/pull/7231/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=7231&range=12
Stats: 638 lines in 36 files changed: 288 ins; 62 del; 288 mod
Patch: https://git.openjdk.java.net/jdk/pull/7231.diff
Fetch: git fetch https://git.openjdk.java.net/jdk pull/7231/head:pull/7231
PR: https://git.openjdk.java.net/jdk/pull/7231
More information about the core-libs-dev
mailing list