RFR: 8279598: Provide adapter from RandomGenerator to Random [v16]
Yasser Bazzi
duke at openjdk.java.net
Fri Mar 11 01:25:28 UTC 2022
> Hi, could i get a review on this implementation proposed by Stuart Marks, i decided to use the https://docs.oracle.com/en/java/javase/17/docs/api/java.base/java/util/random/RandomGenerator.html interface to create the default method `asRandom()` that wraps around the newer algorithms to be used on classes that do not accept the new interface.
>
> Some things to note as proposed by the bug report, the protected method next(int bits) is not overrided and setSeed() method if left blank up to discussion on what to do with it.
>
> Small test done on https://gist.github.com/YShow/da678561419cda8e32fccf3a27a649d4
Yasser Bazzi has updated the pull request incrementally with two additional commits since the last revision:
- Merge branch 'randomwrapper' of https://github.com/YShow/jdk.git into randomwrapper
- Remove atomicLong allocation and override next(int) method to throw UOE
-------------
Changes:
- all: https://git.openjdk.java.net/jdk/pull/7001/files
- new: https://git.openjdk.java.net/jdk/pull/7001/files/d6376b29..8155593e
Webrevs:
- full: https://webrevs.openjdk.java.net/?repo=jdk&pr=7001&range=15
- incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=7001&range=14-15
Stats: 7 lines in 1 file changed: 6 ins; 0 del; 1 mod
Patch: https://git.openjdk.java.net/jdk/pull/7001.diff
Fetch: git fetch https://git.openjdk.java.net/jdk pull/7001/head:pull/7001
PR: https://git.openjdk.java.net/jdk/pull/7001
More information about the core-libs-dev
mailing list