RFR: 8279598: Provide adapter from RandomGenerator to Random [v16]
Yasser Bazzi
duke at openjdk.java.net
Sat Mar 12 01:26:25 UTC 2022
On Fri, 11 Mar 2022 01:25:28 GMT, Yasser Bazzi <duke at openjdk.java.net> wrote:
>> Hi, could i get a review on this implementation proposed by Stuart Marks, i decided to use the https://docs.oracle.com/en/java/javase/17/docs/api/java.base/java/util/random/RandomGenerator.html interface to create the default method `asRandom()` that wraps around the newer algorithms to be used on classes that do not accept the new interface.
>>
>> Some things to note as proposed by the bug report, the protected method next(int bits) is not overrided and setSeed() method if left blank up to discussion on what to do with it.
>>
>> Small test done on https://gist.github.com/YShow/da678561419cda8e32fccf3a27a649d4
>
> Yasser Bazzi has updated the pull request incrementally with two additional commits since the last revision:
>
> - Merge branch 'randomwrapper' of https://github.com/YShow/jdk.git into randomwrapper
> - Remove atomicLong allocation and override next(int) method to throw UOE
Alright all changes were made, tests passed
-------------
PR: https://git.openjdk.java.net/jdk/pull/7001
More information about the core-libs-dev
mailing list