RFR: JDK-8283075: Bad IllegalArgumentException message when calling ClassDesc.arrayType(int) which results in a rank > 255 [v2]

ExE Boss duke at openjdk.java.net
Tue Mar 15 13:55:40 UTC 2022


On Tue, 15 Mar 2022 07:50:29 GMT, Peter Levart <plevart at openjdk.org> wrote:

>> Joe Darcy has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Respond to review feedback.
>
> src/java.base/share/classes/java/lang/constant/ClassDesc.java line 179:
> 
>> 177:         int netRank;
>> 178:         if (rank <= 0) {
>> 179:             throw new IllegalArgumentException("rank " + rank + "is not a positive value");
> 
> There's a space missing in the IAE message after the rank number. For example, if rank == 0, the message would be: "rank 0is not positive value" ...

Suggestion:

            throw new IllegalArgumentException("rank " + rank + " is not a positive value");

-------------

PR: https://git.openjdk.java.net/jdk/pull/7812


More information about the core-libs-dev mailing list