RFR: 8279598: Provide adapter from RandomGenerator to Random [v18]

Stuart Marks smarks at openjdk.java.net
Wed Mar 16 06:54:55 UTC 2022


On Tue, 15 Mar 2022 23:18:24 GMT, Yasser Bazzi <duke at openjdk.java.net> wrote:

>> Hi, could i get a review on this implementation proposed by Stuart Marks, i decided to use the https://docs.oracle.com/en/java/javase/17/docs/api/java.base/java/util/random/RandomGenerator.html interface to create the default method `asRandom()` that wraps around the newer algorithms to be used on classes that do not accept the new interface.
>> 
>> Some things to note as proposed by the bug report, the protected method next(int bits) is not overrided and setSeed() method if left blank up to discussion on what to do with it.
>> 
>> Small test done on https://gist.github.com/YShow/da678561419cda8e32fccf3a27a649d4
>
> Yasser Bazzi has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fix SplittableRandomTest.

src/java.base/share/classes/java/util/Random.java line 320:

> 318:      * @param generator the {@code RandomGenerator} calls are delegated to
> 319:      * @return the delegating {@code Random} instance
> 320:      * @throws NullPointerException if generator is null

One more small thing. Add this line after the `@throws` line:

     * @since 19

Thanks.

-------------

PR: https://git.openjdk.java.net/jdk/pull/7001


More information about the core-libs-dev mailing list