RFR: 8278794: Infinite loop in DeflaterOutputStream.finish() [v2]
Ravi Reddy
rreddy at openjdk.java.net
Wed Mar 16 16:34:37 UTC 2022
> Hi All,
>
> This review request contains fix for infinite loop issue in DeflaterOutputStream.finish() in an exception scenario.
> 1. The issue is with 'finished' flag not getting set to correct value when there is an IOException in
> DeflaterOutputStream.finish() which will result in Infinite loops for next write operations on the same deflater.
> 2. Tighten the condition(to close deflater) in ZipOutputStream using an already existing 'finish' flag in Deflater class.
> 3. Added Inflater exception scenarios also to the test case, renaming test case to CloseInflaterDeflaterTest.java from CloseDeflaterTest.java
>
> Thanks,
> Ravi
Ravi Reddy has updated the pull request incrementally with one additional commit since the last revision:
Modified write(byte []b) to write(byte[] b) to maintain same signature across the test case
-------------
Changes:
- all: https://git.openjdk.java.net/jdk/pull/7804/files
- new: https://git.openjdk.java.net/jdk/pull/7804/files/5700e194..c50aa1bd
Webrevs:
- full: https://webrevs.openjdk.java.net/?repo=jdk&pr=7804&range=01
- incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=7804&range=00-01
Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod
Patch: https://git.openjdk.java.net/jdk/pull/7804.diff
Fetch: git fetch https://git.openjdk.java.net/jdk pull/7804/head:pull/7804
PR: https://git.openjdk.java.net/jdk/pull/7804
More information about the core-libs-dev
mailing list