RFR: 8278794: Infinite loop in DeflaterOutputStream.finish() [v2]

Ravi Reddy rreddy at openjdk.java.net
Thu Mar 17 16:56:16 UTC 2022


On Wed, 16 Mar 2022 16:34:37 GMT, Ravi Reddy <rreddy at openjdk.org> wrote:

>> Hi All,
>> 
>> This review request contains fix for infinite loop issue in DeflaterOutputStream.finish() in an exception scenario.
>> 1. The issue is with 'finished' flag not getting set to correct value when there is an IOException in 
>>     DeflaterOutputStream.finish() which will result in Infinite loops for next write operations on the same deflater.
>> 2. Tighten the condition(to close deflater) in ZipOutputStream using an already existing 'finish' flag in Deflater class.
>> 3. Added Inflater exception scenarios also to the test case, renaming test case to CloseInflaterDeflaterTest.java from CloseDeflaterTest.java
>> 
>> Thanks,
>> Ravi
>
> Ravi Reddy has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Modified write(byte []b) to write(byte[] b) to maintain same signature across the test case

> 

Thanks Lance for the review , In the latest commit , I have formatted the comments in the test case.

-------------

PR: https://git.openjdk.java.net/jdk/pull/7804


More information about the core-libs-dev mailing list