RFR: 8278794: Infinite loop in DeflaterOutputStream.finish() [v3]

[Lance Andersen]

On Thu, 17 Mar 2022 16:56:15 GMT, Ravi Reddy <rreddy at openjdk.org> wrote:

>> Hi All,
>> 
>> This review request contains fix for infinite loop issue in DeflaterOutputStream.finish() in an exception scenario.
>> 1. The issue is with 'finished' flag not getting set to correct value when there is an IOException in 
>>     DeflaterOutputStream.finish() which will result in Infinite loops for next write operations on the same deflater.
>> 2. Tighten the condition(to close deflater) in ZipOutputStream using an already existing 'finish' flag in Deflater class.
>> 3. Added Inflater exception scenarios also to the test case, renaming test case to CloseInflaterDeflaterTest.java from CloseDeflaterTest.java
>> 
>> Thanks,
>> Ravi
>
> Ravi Reddy has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Modified the format of comments across the test case and also done clean up of test case by using less data providers

Hi Ravi,

Thank you for cleaning up the comments.  Much appreciated!

-------------

Marked as reviewed by lancea (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/7804