RFR: 8283349 : Robustness improvements to java/util/prefs/AddNodeChangeListener.jar
Brent Christian
bchristi at openjdk.java.net
Tue Mar 22 18:06:10 UTC 2022
Please review this change to the java/util/prefs/AddNodeChangeListener.jar test.
Although the test specifies "-Djava.util.prefs.userRoot=." to ensure a fresh Preferences on each test run, MacOS does not seem to honor this, and still stores prefs in Library/.
This test has long suffered intermittent failures. 8255031 added some debugging code; as of that change, the test fails fast as soon as an expected change event is not received. In particular, if the expected event is not received for adding the node, the test exits without removing the node. In this way, on Mac, the node can get "stuck" in the preferences of the machine. Future runs on the machine will already have the node, no node added change event will be generated (because the node was already there), the test will continue to fail without removing the node, etc. This matches observations on some CI machines.
This change ensures that:
* the test node is not present before the test
* the test runs to completion, including removing the test node
* the test node is not left behind after the test
Thanks.
-------------
Commit messages:
- Ensure test node does not already exist, and is always removed
Changes: https://git.openjdk.java.net/jdk/pull/7908/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=7908&range=00
Issue: https://bugs.openjdk.java.net/browse/JDK-8283349
Stats: 70 lines in 1 file changed: 30 ins; 17 del; 23 mod
Patch: https://git.openjdk.java.net/jdk/pull/7908.diff
Fetch: git fetch https://git.openjdk.java.net/jdk pull/7908/head:pull/7908
PR: https://git.openjdk.java.net/jdk/pull/7908
More information about the core-libs-dev
mailing list