RFR: 8283279: [Testbug] Improve TestGetSwapSpaceSize [v2]

[Severin Gehwolf]

On Wed, 23 Mar 2022 03:06:00 GMT, Jie Fu <jiefu at openjdk.org> wrote:

>> Severin Gehwolf has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
>> 
>>  - Incorporate review feedback
>>  - Merge branch 'master' into test_getswapspace_improvement_8283279
>>  - 8283279: [Testbug] Improve TestGetSwapSpaceSize
>
> Please also update the copyright year.
> Thanks.

Thanks for the review, @DamonFool! Updated the patch.

> test/jdk/jdk/internal/platform/docker/GetFreeSwapSpaceSize.java line 28:
> 
>> 26: 
>> 27: // Usage:
>> 28: //   GetFreeSwapSpaceSize <memoryAlloc> <memory> <memorySwapAlloc> <expectedSwap>
> 
> I would suggest
> 
> //   GetFreeSwapSpaceSize <memoryAlloc> <expectedMemory> <memorySwapAlloc> <expectedSwap>

Thanks, fixed.

> test/jdk/jdk/internal/platform/docker/GetFreeSwapSpaceSize.java line 32:
> 
>> 30:     public static void main(String[] args) {
>> 31:         if (args.length != 4) {
>> 32:             throw new RuntimeException("Unexpected arguments. Expected 2, got " + args.length);
> 
> Shouldn't be `Expected 4` ?

Yes. Fixed now.

-------------

PR: https://git.openjdk.java.net/jdk/pull/7854