RFR: 8282508: Updating ASM to 9.2 for JDK 19
Rémi Forax
forax at openjdk.java.net
Mon Mar 28 17:53:47 UTC 2022
On Mon, 28 Mar 2022 16:49:58 GMT, Vicente Romero <vromero at openjdk.org> wrote:
> Please review this PR which is updating the ASM included in the JDK to ASM 9.2. This version should be included in JDK19. There are basically two commits here, one that was automatically generated and that mostly changes file headers etc and another one, smaller, that make changes to the code to adapt it to our needs, JDK version etc. In this second commit one can see that two classes that were removed by the automatically generated change have been copied back:
>
> jdk.internal.org.objectweb.asm.commons.RemappingMethodAdapter
> jdk.internal.org.objectweb.asm.commons.RemappingAnnotationAdapter
>
> This is because package: `jdk.jfr.internal.instrument` needs them.
>
> TIA
I suppose that you are raising commons.RemappingMethodAdapter and commons.RemappingAnnotationAdapter from the dead because you want to fix the code in jdk.jfr.internal.instrument later ?
Otherwise it's a little dangerous because that code as started to drift, the new remapper has new code not supported by the old remapper. BTW, @deprecated on ASM source is equivalent to. @Deprecated + forRemoval in the JDK.
The support of Java 19 is fine, the same code will be included in ASM soon.
-------------
PR: https://git.openjdk.java.net/jdk/pull/8000
More information about the core-libs-dev
mailing list